Child Item

what should be a file download path

what is the correct download path :

 mDbxClient.files().download(Path =?);

 mDbxClient.files().download("https://www.dropbox.com/home/Apps/AndroidDbAppStorage")
                        .download(outputStream);

here its my code :

public  class DownloadFileTask extends AsyncTask<FileMetadata, Void, File> {

private final Context mContext;
private final DbxClientV2 mDbxClient;
    String name,path;
private  File file;
    DownloadFileTask(Context context, DbxClientV2 dbxClient, String path,String name) {
mContext = context;
mDbxClient = dbxClient;
this.path = path;
this.name=name;
    }

@Override
    protected File doInBackground(FileMetadata... params) {
try {
file=new File(path+name);
// Download the file.
                OutputStream outputStream = new FileOutputStream(file);
mDbxClient.files().download("https://www.dropbox.com/home/Apps/AndroidDbAppStorage")
                        .download(outputStream);

// Tell android about the file
            Intent intent = new Intent(mContext, LoginActivity.class);
mContext.startActivity(intent);

return file;
        } catch (DbxException | IOException e) {
        }

return null;
    }

@Override
    protected void onPostExecute(File result) {
super.onPostExecute(result);
if (result.length()!=0) {
            Toast.makeText(mContext, "File downloaded", Toast.LENGTH_SHORT).show();
        } else {

        }
    }
}

Find more posts tagged with

Developers

Comments

kmsbs

what is the path pattern :

mDbxClient.files().download("https://www.dropbox.com/home/Apps/AndroidDbAppStorage/"+name)
.download(outputStream);

Greg-DB

The path values you supply to the API should be paths relative to the root of the Dropbox account (or relative to the app folder root, if you're using an app with the app folder permission), not Dropbox web site URLs as you have here.

So, for example, to upload a file "myfile.txt" to your root, you would use "/myfile.txt". Or, to upload it into a subfolder "Documents", you would use "/Documents/myfile.txt".

You can also get the correct path values from Metadata.getPathLower, if/when you get the metadata for existing files elsewhere on the API:

https://dropbox.github.io/dropbox-sdk-java/api-docs/v3.0.x/com/dropbox/core/v2/files/Metadata.html#getPathLower--

kmsbs

here my path :

/Apps/AndroidDbAppStorage/"+name

it return empty file.

Greg-DB

If the download call is returning successfully but is yielding a 0 byte file, it's likely because the file you have uploaded to Dropbox is 0 bytes long. You can check the Dropbox web site to confirm that.

If you don't expect to have a 0 byte file uploaded, you should check on where/how you're uploading it, and then upload the correct version.

kmsbs

File contain data and the size is in kb

Greg-DB

If something's not working as expected, I'll be happy to help, but I'll need some more information. Please reply with the following for the current issue:

- the version number of the SDK/library you are using
- the steps to reproduce the current issue, including relevant code snippet(s)
- the full text of the unexpected output
- a screenshot showing where you're checking that the file is not actually 0 bytes

kmsbs

sdk version=

'com.dropbox.core:dropbox-core-sdk:3.0.8'

code :

public  class DownloadFileTask extends AsyncTask<FileMetadata, Void, File> {

private final Context mContext;
private final DbxClientV2 mDbxClient;
    String name,path;
private  File file;
    DownloadFileTask(Context context, DbxClientV2 dbxClient, String path,String name) {
mContext = context;
mDbxClient = dbxClient;
this.path = path;
this.name=name;
    }

@Override
    protected File doInBackground(FileMetadata... params) {
try {
file=new File(path+name);
// Download the file.
                OutputStream outputStream = new FileOutputStream(file);
mDbxClient.files().download("/Apps/AndroidDbAppStorage/"+name)
                        .download(outputStream);

return file;
        } catch (DbxException | IOException e) {
        }

return null;
    }

@Override
    protected void onPostExecute(File result) {
super.onPostExecute(result);
if (result.length()!=0) {
            Toast.makeText(mContext, "File downloaded", Toast.LENGTH_SHORT).show();
            Intent intent = new Intent(mContext, LoginActivity.class);
mContext.startActivity(intent);
        } else {

        }
    }
}

it return empty file

Greg-DB

I don't see anything obviously wrong in this code. It seems to be mostly copied/modified from the sample.

Can you share the other things I requested though? I.e., the output you're getting, and how you're checking the original file? I recall from your previous thread that you had an issue in your code that result in 0 byte files being uploaded to you account. It sounds like you perhaps didn't fix all of them.

kmsbs

details_item-that file i want to import

kmsbs

output:
java.lang.NullPointerException: Attempt to invoke virtual method 'long java.io.File.length()' on a null object reference
at line :
protected void onPostExecute(File result) {
super.onPostExecute(result);
if (result.length()!=0) {
Toast.makeText(mContext, "File downloaded", Toast.LENGTH_SHORT).show();
Intent intent = new Intent(mContext, LoginActivity.class);
mContext.startActivity(intent);
} else {

}
}

Greg-DB

Thanks for sharing that error output! That shows that you're getting a 'NullPointerException' for the 'File result' in your 'onPostExecute'. That is, the object itself is null, which is not the same as saying the downloaded file has zero length.

You'll need to investigate why your code isn't actually returning the 'file' object. I suspect it's because something is going wrong with the downloading or writing of the file, but, upon closer inspection of your code, it seems you're not seeing it because you're silently throwing away potential exceptions here:

} catch (DbxException | IOException e) {
}

You should add error handling there to take handle any issues that may arise (e.g., if you don't have permission to write to the local file path you specified, etc.).

kmsbs

this is the error :

com.dropbox.core.v2.files.DownloadErrorException: Exception in 2/files/download: {".tag":"path","path":"not_found"}

Greg-DB

@kmsbs Please don't post the same question in multiple places. It makes it harder to keep track of your question(s), and can cause spam for other people on older threads.

I see you also posted a new thread for this, so I'll follow up there:

https://www.dropboxforum.com/t5/API-Support-Feedback/path-not-found-error/m-p/284453#M17409